Divyanshu/Saurabh | Design issue fix#508
Merged
Saurabh186 merged 5 commits intodevelopmentfrom Mar 31, 2026
Merged
Conversation
…n/proxy-ui into divyanshu-dev
- Replace `broder-color` typo with `border-color` throughout templates - Introduce `card-with-header` and `card-with-header--header` utility classes for consistent card styling - Remove inline background color utilities in favor of `bg-color` class - Remove unused `preview-input-field` styles from SCSS - Remove `max-width` constraint from code snippet view - Simplify chip and badge styling by removing redundant color utilities - Update
…n/proxy-ui into divyanshu-dev
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
There was a problem hiding this comment.
Other comments (9)
- apps/36-blocks/src/app/logs/log/log.component.html (220-220) The removal of styling classes for user IP addresses and endpoints (like `bg-[var(--color-common-chip-bg)]` and `[color:var(--color-common-text-2)]`) may reduce visual distinction for these technical elements. Consider maintaining some form of visual differentiation for these fields to improve readability, especially since they contain code-like content that benefits from visual separation.
- apps/36-blocks/src/app/features/create-feature/create-feature.component.html (1083-1083) The div on line 1083 was changed from 'flex-col' to 'items-center' which might affect the layout. Verify that this change doesn't break the intended design.
- apps/36-blocks/src/app/layout/main-left-side-nav/main-left-side-nav.component.scss (1-1) The removal of the `:host a.active-list-item::before` styling will eliminate the visual indication for active/selected navigation items. If this was intentional, please ensure there's an alternative way to highlight the active item in the new `.service-list` structure.
- apps/36-blocks/src/app/users/user/user.component.html (125-125) I notice that several CSS classes with color variables like `[color:var(--color-common-text-2)]` and `bg-[var(--color-common-chip-bg)]` have been removed. Are these styles being applied globally now? If not, this could lead to inconsistent styling across the application.
- apps/36-blocks/src/app/users/user/user.component.html (149-149) The block name display has been changed from a styled chip to plain text. This is a significant UI change that might affect visual hierarchy. Was this intentional? Consider keeping some form of visual distinction for block names if they represent important categorization.
- apps/36-blocks/src/app/features/create-feature/create-feature.component.html (1866-1866) There's still one instance of the typo 'broder-color' that should be changed to 'border-color' for consistency.
- apps/36-blocks/src/app/users/management/management.component.html (250-250) There's a typo in the CSS class name 'broder-color' which should be 'border-color'. This could cause styling inconsistencies.
-
apps/36-blocks/src/app/users/management/management.component.html (250-250)
There's a redundant 'bg-color' class applied twice to the same div element.
<div class="flex gap-2 px-4 py-3 border-t border-color bg-color"> - apps/36-blocks/src/app/features/create-feature/create-feature.component.html (820-820) The input placeholder capitalization is inconsistent. Consider changing 'Password' to lowercase 'password' to match the style of the email/phone field.
💡 To request another review, post a new comment with "/windsurf-review".
Comment on lines
3
to
4
| min-width: 500px; | ||
| max-width: 800px; | ||
| } |
There was a problem hiding this comment.
Removing the max-width constraint from .code-snippet-view might cause content to stretch too wide on larger screens. Consider if this was intentional or if a different max-width value would be more appropriate to maintain readability.
| @@ -1,5 +1,5 @@ | |||
| @if (loading$ | async; as loading) { | |||
| <div class="app-content flex flex-col"> | |||
| <div class="flex flex-col"> | |||
There was a problem hiding this comment.
The app-content class has been removed from the main container div. Ensure this doesn't break the component's layout within the application context, especially regarding padding, margins, or other layout properties that might have been provided by this class.
| } | ||
| </div> | ||
| <div class="flex-1 flex flex-col overflow-hidden"> | ||
| <div class="flex-1 flex flex-col app-content"> |
There was a problem hiding this comment.
The overflow-hidden property was removed from the content container. This might cause content to overflow its container when there's a lot of data. Consider adding appropriate overflow handling to the app-content class.
Saurabh186
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self